zentol commented on code in PR #19619:
URL: https://github.com/apache/flink/pull/19619#discussion_r904913804
##########
docs/content.zh/docs/ops/debugging/debugging_classloading.md:
##########
@@ -167,7 +167,9 @@ Common causes for class leaks and suggested fixes:
interners, or Avro's class/object caches in the serializers.
- *JDBC*: JDBC drivers leak references outside the user code classloader. To
ensure that these classes are only loaded once
- you should either add the driver jars to Flink's `lib/` folder, or add the
driver classes to the list of parent-first loaded class via
[`classloader.parent-first-patterns-additional`]({{< ref
"docs/deployment/config" >}}#classloader-parent-first-patterns-additional).
+ you should add the driver jars to Flink's `lib/` folder intead of bundling
them in the user-jar.
Review Comment:
```suggestion
you should add the driver jars to Flink's `lib/` folder instead of
bundling them in the user-jar.
```
##########
docs/content/docs/ops/debugging/debugging_classloading.md:
##########
@@ -166,7 +166,9 @@ Common causes for class leaks and suggested fixes:
interners, or Avro's class/object caches in the serializers.
- *JDBC*: JDBC drivers leak references outside the user code classloader. To
ensure that these classes are only loaded once
- you should either add the driver jars to Flink's `lib/` folder, or add the
driver classes to the list of parent-first loaded class via
[`classloader.parent-first-patterns-additional`]({{< ref
"docs/deployment/config" >}}#classloader-parent-first-patterns-additional).
+ you should add the driver jars to Flink's `lib/` folder intead of bundling
them in the user-jar.
Review Comment:
```suggestion
you should add the driver jars to Flink's `lib/` folder instead of
bundling them in the user-jar.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
