[ https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458030#comment-15458030 ]
ASF GitHub Bot commented on FLINK-4490: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2447#discussion_r77317670 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/SlotOwner.java --- @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.jobmanager.slots; + +import org.apache.flink.runtime.instance.Slot; + +/** + * Interface for components that hold slots and to which slots get released / recycled. + */ +public interface SlotOwner { + + boolean returnAllocatedSlot(Slot slot); --- End diff -- JavaDocs are missing (even though the method is quite self-explanatory...) > Decouple Slot and Instance > -------------------------- > > Key: FLINK-4490 > URL: https://issues.apache.org/jira/browse/FLINK-4490 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination > Reporter: Kurt Young > Fix For: 1.2.0 > > > Currently, {{Slot}} and {{Instance}} holds each other. For {{Instance}} > holding {{Slot}}, it makes sense because it reflects how many resources it > can provide and how many are using. > But it's not very necessary for {{Slot}} to hold {{Instance}} which it > belongs to. It only needs to hold some connection information and gateway to > talk to. Another downside for {{Slot}} holding {{Instance}} is that > {{Instance}} actually contains some allocate/de-allocation logicals, it will > be difficult if we want to do some allocation refactor without letting > {{Slot}} noticed. > We should abstract the connection information of {{Instance}} to let {{Slot}} > holds. (Actually we have {{InstanceConnectionInfo}} now, but lacks of > instance's akka gateway, maybe we can just adding the akka gateway to the > {{InstanceConnectionInfo}}) -- This message was sent by Atlassian JIRA (v6.3.4#6332)