JingsongLi commented on code in PR #171:
URL: https://github.com/apache/flink-table-store/pull/171#discussion_r905881398
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/RecordWriter.java:
##########
@@ -32,9 +33,18 @@
*/
public interface RecordWriter<T> {
+ /** Open the record write. */
+ void open(MemorySegmentPool memoryPool);
Review Comment:
The current AppendOnlyWriter also has memory problems. When there are too
many partitions, the ORC Writer's VectorizedRowBatch will also take up a lot of
memory, leading to OOM.
I'm considering whether I can also bring to AppendOnly in the future the
ability to.
- ORC writer's memory can be pooled
- Or put records into MemorySegment first, then write the file
So I introduce this to `RecordWriter` interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
