gyfora commented on code in PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#discussion_r906772317
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/FlinkReconciler.java: ########## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.reconciler.deployment; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.kubernetes.operator.config.FlinkConfigManager; +import org.apache.flink.kubernetes.operator.config.KubernetesOperatorConfigOptions; +import org.apache.flink.kubernetes.operator.crd.AbstractFlinkResource; +import org.apache.flink.kubernetes.operator.crd.FlinkDeployment; +import org.apache.flink.kubernetes.operator.crd.spec.AbstractFlinkSpec; +import org.apache.flink.kubernetes.operator.crd.spec.JobSpec; +import org.apache.flink.kubernetes.operator.crd.spec.JobState; +import org.apache.flink.kubernetes.operator.crd.status.CommonStatus; +import org.apache.flink.kubernetes.operator.crd.status.JobManagerDeploymentStatus; +import org.apache.flink.kubernetes.operator.crd.status.ReconciliationState; +import org.apache.flink.kubernetes.operator.crd.status.ReconciliationStatus; +import org.apache.flink.kubernetes.operator.reconciler.Reconciler; +import org.apache.flink.kubernetes.operator.reconciler.ReconciliationUtils; +import org.apache.flink.kubernetes.operator.service.FlinkService; +import org.apache.flink.kubernetes.operator.utils.EventRecorder; +import org.apache.flink.kubernetes.operator.utils.FlinkUtils; + +import io.fabric8.kubernetes.api.model.ObjectMeta; +import io.fabric8.kubernetes.client.KubernetesClient; +import io.javaoperatorsdk.operator.api.reconciler.Context; +import io.javaoperatorsdk.operator.api.reconciler.DeleteControl; +import org.apache.commons.lang3.StringUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.time.Duration; +import java.time.Instant; +import java.util.Optional; + +/** Base class for all Flink resource reconcilers. */ +public abstract class FlinkReconciler< + CR extends AbstractFlinkResource<SPEC, STATUS>, + SPEC extends AbstractFlinkSpec, + STATUS extends CommonStatus<SPEC>> + implements Reconciler<CR> { + + private static final Logger LOG = LoggerFactory.getLogger(FlinkReconciler.class); + + protected final FlinkConfigManager configManager; + protected final EventRecorder eventRecorder; + protected final KubernetesClient kubernetesClient; + protected final FlinkService flinkService; + + public FlinkReconciler( + KubernetesClient kubernetesClient, + FlinkService flinkService, + FlinkConfigManager configManager, + EventRecorder eventRecorder) { + this.kubernetesClient = kubernetesClient; + this.flinkService = flinkService; + this.configManager = configManager; + this.eventRecorder = eventRecorder; + } + + @Override + public final void reconcile(CR cr, Context ctx) throws Exception { + if (!readyToReconcile(cr, ctx)) { + LOG.info("Not ready for reconciliation yet..."); + return; + } + + var status = cr.getStatus(); + if (status.getReconciliationStatus().getLastReconciledSpec() == null) { + var spec = cr.getSpec(); + var deployConfig = getDeployConfig(cr.getMetadata(), spec, ctx); + + LOG.debug("Deploying for the first time"); + deploy( + cr.getMetadata(), + spec, + status, + deployConfig, + Optional.ofNullable(spec.getJob()).map(JobSpec::getInitialSavepointPath), + false); + ReconciliationUtils.updateForSpecReconciliationSuccess( Review Comment: I would like to keep it here to avoid adding extre boilerplate. During initial deployment this is always running anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
