[
https://issues.apache.org/jira/browse/FLINK-28252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alvin Tan Jian Jia updated FLINK-28252:
---------------------------------------
Description:
*Summary*
I have identified a few classes with refactoring potential, specifically on
subtask. The issue was refactored once on May 25, 2022 along with other classes
in commit e68d679e8aca9b8b17e1b667188545c915a137d0. Is it possible to improve
the overall package of subtasks further? I am probably not qualified and
experienced enough to point out the exact code needs to be refactored, given my
limited knowledge of the project and codebase.
*Urgency*
Low priority. For maintenance of code in the long run.
Hi,
I am currently doing some research on Estimating Time Taken for Software
Refactoring. Flink is one of my case studies being a highly popular project.
Would appreciate your kind feedback on the appropriateness of the estimated
time to refactor.
I am specifically looking at potential for refactoring, such as breaking
functions that are too long into shorter functions, or to remove code
duplication. Would you agree that there could be some modification to the code
to make it better in the listed classes? And if so, is the estimated time
appropriate to carry out the improvement? I will be grateful for any help you
can provide.
# StreamTask.java - 4 hours
# SubtaskCheckpointCoordinator.java - 3.5 hours
# SubtaskCheckpointCoordinatorImpl.java - 4.5 hours
The attached csv file contains the other recommendations from my research.
Thank you once again for any help you can provide.
Regards,
Alvin
was:
*Summary*
I have identified a few classes with refactoring potential, specifically on
subtask. The issue was refactored once on May 25, 2022 along with other classes
in commit e68d679e8aca9b8b17e1b667188545c915a137d0. Is it possible to improve
the overall package of error handlers further? I am probably not qualified and
experienced enough to point out the exact code needs to be refactored, given my
limited knowledge of the project and codebase.
*Urgency*
Low priority. For maintenance of code in the long run.
Hi,
I am currently doing some research on Estimating Time Taken for Software
Refactoring. Flink is one of my case studies being a highly popular project.
Would appreciate your kind feedback on the appropriateness of the estimated
time to refactor.
I am specifically looking at potential for refactoring, such as breaking
functions that are too long into shorter functions, or to remove code
duplication. Would you agree that there could be some modification to the code
to make it better in the listed classes? And if so, is the estimated time
appropriate to carry out the improvement? I will be grateful for any help you
can provide.
# StreamTask.java - 4 hours
# SubtaskCheckpointCoordinator.java - 3.5 hours
# SubtaskCheckpointCoordinatorImpl.java - 4.5 hours
The attached csv file contains the other recommendations from my research.
Thank you once again for any help you can provide.
Regards,
Alvin
> Potential Refactoring
> ---------------------
>
> Key: FLINK-28252
> URL: https://issues.apache.org/jira/browse/FLINK-28252
> Project: Flink
> Issue Type: Improvement
> Reporter: Alvin Tan Jian Jia
> Priority: Minor
> Attachments: Flink_release-1.12.5.csv
>
>
> *Summary*
> I have identified a few classes with refactoring potential, specifically on
> subtask. The issue was refactored once on May 25, 2022 along with other
> classes in commit e68d679e8aca9b8b17e1b667188545c915a137d0. Is it possible
> to improve the overall package of subtasks further? I am probably not
> qualified and experienced enough to point out the exact code needs to be
> refactored, given my limited knowledge of the project and codebase.
> *Urgency*
> Low priority. For maintenance of code in the long run.
> Hi,
> I am currently doing some research on Estimating Time Taken for Software
> Refactoring. Flink is one of my case studies being a highly popular project.
> Would appreciate your kind feedback on the appropriateness of the estimated
> time to refactor.
> I am specifically looking at potential for refactoring, such as breaking
> functions that are too long into shorter functions, or to remove code
> duplication. Would you agree that there could be some modification to the
> code to make it better in the listed classes? And if so, is the estimated
> time appropriate to carry out the improvement? I will be grateful for any
> help you can provide.
> # StreamTask.java - 4 hours
> # SubtaskCheckpointCoordinator.java - 3.5 hours
> # SubtaskCheckpointCoordinatorImpl.java - 4.5 hours
>
> The attached csv file contains the other recommendations from my research.
> Thank you once again for any help you can provide.
>
> Regards,
> Alvin
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
