lincoln-lil commented on code in PR #19983: URL: https://github.com/apache/flink/pull/19983#discussion_r908405217
########## docs/content.zh/docs/dev/datastream/operators/asyncio.md: ########## @@ -30,6 +30,8 @@ under the License. 对于不熟悉异步或者事件驱动编程的用户，建议先储备一些关于 Future 和事件驱动编程的知识。 提示：这篇文档 [FLIP-12: 异步 I/O 的设计和实现](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65870673)介绍了关于设计和实现异步 I/O 功能的细节。 +对于新增的重试支持涉及和实现细节可以参考[FLIP-232: 为 DataStream API 异步 I/O 操作增加重试支持](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211883963) Review Comment: good catch! ########## docs/content/docs/dev/datastream/operators/asyncio.md: ########## @@ -32,7 +32,8 @@ event-driven programming may be useful preparation. Note: Details about the design and implementation of the asynchronous I/O utility can be found in the proposal and design document [FLIP-12: Asynchronous I/O Design and Implementation](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65870673). - +Details about the new retry support can be found in document +[FLIP-232: Add Retry Support For Async I/O In DataStream API](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211883963)。 Review Comment: addressed. ########## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AsyncDataStream.java: ########## @@ -66,7 +70,29 @@ private static <IN, OUT> SingleOutputStreamOperator<OUT> addOperator( long timeout, int bufSize, OutputMode mode) { + return addOperator(in, func, timeout, bufSize, mode, NO_RETRY_STRATEGY); Review Comment: Make sense to me, will delete it and use NO_RETRY_STRATEGY for the directly calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
