morhidi commented on PR #268: URL: https://github.com/apache/flink-kubernetes-operator/pull/268#issuecomment-1168659447
Some suggestions: - There's no need for the word counter_ when the metric ends with a counter. - Use the order namespace->flinkdeployment - Use `JOSDK` instead of `operator_sdk` to bring some relief to the tired eyes Use the existing metrics as an example, here we have `resourcens` to differentiate it from operatornamespace ``` flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.Mapped.MemoryUsed: 0 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.resourcens.default.FlinkDeployment.DEPLOYED_NOT_READY.Count: 0 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.CPU.Time: 207210000000 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.Metaspace.Used: 58601696 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.Metaspace.Max: -1 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.Heap.Committed: 331350016 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.GarbageCollector.G1 Young Generation.Count: 8 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.Direct.TotalCapacity: 16778334 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.resourcens.default.FlinkDeployment.READY.Count: 1 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.Direct.MemoryUsed: 16778335 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.Heap.Used: 67083776 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.resourcens.default.FlinkDeployment.Count: 1 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.NonHeap.Max: -1 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.resourcens.default.FlinkDeployment.DEPLOYING.Count: 0 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.resourcens.default.FlinkDeployment.ERROR.Count: 0 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.Direct.Count: 5 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.GarbageCollector.G1 Old Generation.Time: 0 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.Metaspace.Committed: 60289024 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.ClassLoader.ClassesLoaded: 10073 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.NonHeap.Committed: 97460224 flink-kubernetes-operator-64d8cc77c4-w49nj.k8soperator.default.flink-kubernetes-operator.Status.JVM.Memory.NonHeap.Used: 93806040 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
