rkhachatryan commented on code in PR #19679: URL: https://github.com/apache/flink/pull/19679#discussion_r909048188
########## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java: ########## @@ -477,6 +478,50 @@ KeyGroupedInternalPriorityQueue<T> create( } } + @Override + public <N, S extends State, V> S upgradeKeyedState( + TypeSerializer<N> namespaceSerializer, StateDescriptor<S, V> stateDescriptor) + throws Exception { + StateFactory stateFactory = getStateFactory(stateDescriptor); + Tuple2<ColumnFamilyHandle, RegisteredKeyValueStateBackendMetaInfo<N, V>> registerResult = + tryRegisterKvStateInformation(stateDescriptor, namespaceSerializer, noTransform()); + Preconditions.checkState(kvStateInformation.containsKey(stateDescriptor.getName())); + kvStateInformation.computeIfPresent( + stateDescriptor.getName(), + (stateName, kvStateInfo) -> + new RocksDbKvStateInfo( + kvStateInfo.columnFamilyHandle, + new RegisteredKeyValueStateBackendMetaInfo<>( + kvStateInfo.metaInfo.snapshot()))); + return stateFactory.createState( + stateDescriptor, registerResult, RocksDBKeyedStateBackend.this); Review Comment: I think we are all on the same page now and it makes sense to document this design somehwere, along with other aspects of this feature - for future reference (as well as to make sure we're indeed on the same page). WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org