gyfora commented on PR #268: URL: https://github.com/apache/flink-kubernetes-operator/pull/268#issuecomment-1169733706
I agree with @morhidi said. Lets look at some concrete examples: ``` 1. operator_sdk.event_ResourceEvent.count: 2 2. operator_sdk.event_ResourceEvent.counter_events_received.count: 2 3. operator_sdk.event_ResourceEvent.counter_events_received.resource_basic-example.count: 2 4. operator_sdk.event_ResourceEvent.counter_events_received.resource_basic-example.namespace_default.count: 2 5. operator_sdk.event_ResourceEvent.counter_events_received.resource_basic-example.namespace_default.scope_namespace.count: 2 ``` These are all completely redundant and have some completely unnecessary levels. It probably should be ``` 1. JOSDK.ResourceEvent.received.count: 2 2. JOSDK.ResourceEvent.received.resourcens.default.resource.basic-example.count: 2 ``` Another example: ``` 1. operator_sdk.counter_reconciliations_started.count: 3 2. operator_sdk.counter_reconciliations_started.resource_basic-example.count: 3 3. operator_sdk.counter_reconciliations_started.resource_basic-example.namespace_default.count: 3 4. operator_sdk.counter_reconciliations_started.resource_basic-example.namespace_default.scope_namespace.count: 3 ``` should be: ``` 1. JOSDK.reconciliation.started.count: 3 2. JOSDK.reconciliation.started.resourcens.default.resource.basic-example.count: 3 ``` It is very important to use the groups correctly instead of creating these random `_` connected names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
