rkhachatryan commented on code in PR #20093:
URL: https://github.com/apache/flink/pull/20093#discussion_r909636078
##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java:
##########
@@ -83,14 +88,15 @@ public StateChangeFsUploader(
}
public StateChangeFsUploader(
+ JobID jobID,
Path basePath,
FileSystem fileSystem,
boolean compression,
int bufferSize,
ChangelogStorageMetricGroup metrics,
TaskChangelogRegistry changelogRegistry,
BiFunction<Path, Long, StreamStateHandle> handleFactory) {
- this.basePath = basePath;
+ this.basePath = new Path(basePath, String.format(DSTL_SUB_PATH,
jobID.toString()));
Review Comment:
Wouldn't it be more safe to explicitly call `jobID.toHexString()` instead of
`jobID.toString()`?
##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java:
##########
@@ -54,6 +55,8 @@
public class StateChangeFsUploader implements StateChangeUploader {
private static final Logger LOG =
LoggerFactory.getLogger(StateChangeFsUploader.class);
+ private static final String DSTL_SUB_PATH = "%s/dstl";
+
Review Comment:
Could you explain the purpose of the `/dstl` suffix here?
Isn't this `DSTL_SUB_PATH` already appended to a path where changelog files
reside?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
