zhuzhurk commented on code in PR #20056:
URL: https://github.com/apache/flink/pull/20056#discussion_r910569216


##########
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/decorators/InitTaskManagerDecoratorTest.java:
##########
@@ -179,11 +179,24 @@ void testMainContainerPorts() {
     @Test
     void testMainContainerEnv() {

Review Comment:
   This method seems to test if 
`ResourceManagerOptions.CONTAINERIZED_TASK_MANAGER_ENV_PREFIX` is correctly 
added as container env vars, I would suggest to create a separate test method 
to test whether node id is correctly set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to