wanglijie95 commented on code in PR #20087:
URL: https://github.com/apache/flink/pull/20087#discussion_r910774779
##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -593,6 +593,40 @@ public enum SchedulerType {
code(SchedulerType.AdaptiveBatch.name()))
.build());
+ @Documentation.Section({
+ Documentation.Sections.EXPERT_SCHEDULING,
+ Documentation.Sections.ALL_JOB_MANAGER
+ })
+ public static final ConfigOption<Boolean> SPECULATIVE_ENABLED =
+ key("jobmanager.adaptive-batch-scheduler.speculative.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Controls whether to enable speculative
execution.");
+
+ @Documentation.Section({
+ Documentation.Sections.EXPERT_SCHEDULING,
+ Documentation.Sections.ALL_JOB_MANAGER
+ })
+ public static final ConfigOption<Integer>
SPECULATIVE_MAX_CONCURRENT_EXECUTIONS =
+
key("jobmanager.adaptive-batch-scheduler.speculative.max-concurrent-executions")
+ .intType()
+ .defaultValue(2)
+ .withDescription(
+ "Controls the maximum number of execution attempts
of each operator, "
+ + "including the original one and
speculative ones, that can "
+ + "execute concurrently.");
+
Review Comment:
Maybe "Controls the maximum number of execution attempts of each operator
that can execute concurrently, including the original one and speculative ones"
##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -593,6 +593,40 @@ public enum SchedulerType {
code(SchedulerType.AdaptiveBatch.name()))
.build());
+ @Documentation.Section({
+ Documentation.Sections.EXPERT_SCHEDULING,
+ Documentation.Sections.ALL_JOB_MANAGER
+ })
+ public static final ConfigOption<Boolean> SPECULATIVE_ENABLED =
Review Comment:
I perfer to add a `ADAPTIVE_BATCH_SCHEDULER` prefix, the same goes for the
other two options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
