afedulov commented on PR #20049:
URL: https://github.com/apache/flink/pull/20049#issuecomment-1170948767
@MartijnVisser the issue is that `@SupressWarnings("deprecation")` are not
considered by the maven-compiler-plugin and we have (somewhat recently) enabled
strict failure on warnings:
https://github.com/afedulov/flink/blob/master/flink-examples/flink-examples-streaming/pom.xml#L154-L155
https://issues.apache.org/jira/browse/FLINK-24833
There are two ways forward:
1. Postpone marking SourceFunction as deprecated and push for finalizing
[FLIP-238](https://cwiki.apache.org/confluence/display/FLINK/FLIP-238%3A+Introduce+FLIP-27-based+Data+Generator+Source)
to migrate all existing sample sources
2. Remove the `failOnWarning` parameter for now and add respective comments
explaining the current state
I would say that our original discussion on the ML converged in the
direction that supports option 2. - mark SourceFunction as deprecated effective
immediately to prevent its further spread and work on closing the gaps as a
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
