[ 
https://issues.apache.org/jira/browse/FLINK-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458908#comment-15458908
 ] 

ASF GitHub Bot commented on FLINK-4570:
---------------------------------------

GitHub user mxm opened a pull request:

    https://github.com/apache/flink/pull/2466

    [FLINK-4570] remove conflicting Unicode character

    This caused Scalastyle to fail, presumably depending on the locale
    used. After a bit of debugging on the Scalastyle plugin I found out that
    the number in the error is the byte position.
    
    "Expected identifier, but got Token(COMMA,,,1772,,)"
    
    head -c 1772 flink-mesos/src/test/scala/org/apache/flink/mesos/Utils.scala
    
    pointed to the Unicode character '⇒' which causes Scalastyle to fail in
    certain environments.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/flink scalastyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2466
    
----
commit 6b6175531a3e4dcb3cef9f518d6e8c5a580bc20a
Author: Maximilian Michels <[email protected]>
Date:   2016-09-02T15:52:51Z

    [FLINK-4570] remove conflicting Unicode character
    
    This caused Scalastyle to fail, presumably depending on the locale
    used. After a bit of debugging on the Scalastyle plugin I found out that
    the number in the error is the byte position.
    
    "Expected identifier, but got Token(COMMA,,,1772,,)"
    
    head -c 1772 flink-mesos/src/test/scala/org/apache/flink/mesos/Utils.scala
    
    pointed to the Unicode character '⇒' which causes Scalastyle to fail in
    certain environments.

----


> Scalastyle Maven plugin fails undeterministically
> -------------------------------------------------
>
>                 Key: FLINK-4570
>                 URL: https://issues.apache.org/jira/browse/FLINK-4570
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.2.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.2.0
>
>
> The style check fails undeterministically in 
> flink-mesos/src/test/scala/org/apache/flink/mesos/Utils.scala
> It sometimes fails in the nightly builds without any changes to the code 
> which lets the style check fail. Not reproduceable locally.
> Failed: https://builds.apache.org/job/flink-snapshot-deployment/205/
> Passes: https://builds.apache.org/job/flink-snapshot-deployment/206/
> Failed: https://builds.apache.org/job/flink-snapshot-deployment/207/
> Could be related to upgrading Scalastyle from 0.5.0 to 0.8.0. As a first 
> step, I will just lower the Scalastyle version to 0.5.0 again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to