JingsongLi commented on code in PR #183:
URL: https://github.com/apache/flink-table-store/pull/183#discussion_r911535709
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/TableStoreSink.java:
##########
@@ -196,7 +165,6 @@ public void applyOverwrite(boolean overwrite) {
this.overwrite = overwrite;
}
- @Override
public void setLockFactory(@Nullable CatalogLock.Factory lockFactory) {
Review Comment:
LockFactory should be provided by our catalog instead of incompatible Flink
Catalog.
Yes, we should provide this lock in our HiveCatalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
