wanglijie95 commented on code in PR #20079: URL: https://github.com/apache/flink/pull/20079#discussion_r911835119
########## flink-runtime/src/main/java/org/apache/flink/runtime/blocklist/BlockedNode.java: ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.blocklist; + +import java.io.Serializable; +import java.util.Collection; +import java.util.Collections; +import java.util.HashSet; +import java.util.Set; + +import static org.apache.flink.util.Preconditions.checkNotNull; +import static org.apache.flink.util.Preconditions.checkState; + +/** This class represents a blocked node record. */ +public class BlockedNode implements Serializable { Review Comment: OK ########## flink-runtime/src/main/java/org/apache/flink/runtime/blocklist/DefaultBlocklistTracker.java: ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.blocklist; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.Iterator; +import java.util.Map; +import java.util.Optional; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** Default implementation of {@link BlocklistTracker}. */ +public class DefaultBlocklistTracker implements BlocklistTracker { + private final Map<String, BlockedNode> blockedNodes = new HashMap<>(); + + /** + * Try to add a new blocked node record. If the node (identified by node id) already exists, the + * newly added one will be merged with the existing one. + * + * @param newNode the new blocked node record + * @return the changed record, or {@link Optional#empty()} if no change + */ + private Optional<BlockedNode> tryAddOrMerge(BlockedNode newNode) { + checkNotNull(newNode); + final String nodeId = newNode.getNodeId(); + final BlockedNode existingNode = blockedNodes.get(nodeId); + + if (existingNode == null) { + blockedNodes.put(nodeId, newNode); + return Optional.of(newNode); + } else if (!existingNode.equals(newNode)) { + BlockedNode merged = BlockedNode.merge(existingNode, newNode); Review Comment: OK ########## flink-runtime/src/main/java/org/apache/flink/runtime/blocklist/BlocklistTracker.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.blocklist; + +import java.util.Collection; + +/** A tracker for blocklist. */ +public interface BlocklistTracker { + + /** + * Add new blocked node records. If a node (identified by node id) already exists, the newly + * added one will be merged with the existing one. + * + * @param newNodes the new blocked node records + * @return the changes of blocklist after execution, which will be synchronized to other JMs/RM + */ + Collection<BlockedNode> addNewBlockedNodes(Collection<BlockedNode> newNodes); + + /** + * Returns whether the given node is blocked. + * + * @param nodeId ID of the node to query + * @return true if the given node is blocked, otherwise false + */ + boolean isBlockedNode(String nodeId); + + /** + * Get all blocked node ids. + * + * @return a collection containing all blocked node ids + */ + Collection<String> getAllBlockedNodeIds(); Review Comment: OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
