[
https://issues.apache.org/jira/browse/FLINK-28345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561406#comment-17561406
]
Martijn Visser commented on FLINK-28345:
----------------------------------------
My concern is that we will have to get more and more database specific
implementations done in the generic JDBC implementation.
Perhaps it's good to give this as input also with regards to
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=217386271
since that should replace the current JDBC implementation.
> Flink JDBC connector should check batch count before flush
> ----------------------------------------------------------
>
> Key: FLINK-28345
> URL: https://issues.apache.org/jira/browse/FLINK-28345
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / JDBC
> Affects Versions: 1.15.0, 1.14.5
> Reporter: Feng Jin
> Priority: Major
>
> org.apache.flink.connector.jdbc.internal.JdbcOutputFormat#flush
> {code:java}
> //代码占位符
> @Override
> public synchronized void flush() throws IOException {
> checkFlushException();
> for (int i = 0; i <= executionOptions.getMaxRetries(); i++) {
> try {
> attemptFlush();
> batchCount = 0;
> break;
> ....{code}
> When flush the batch, we should check batchCount is grater than 0. Other
> wise it would cause some problem with some drivers that do not support empty
> batches, like clickhouse jdbc driver.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
