dzikosc commented on code in PR #20133:
URL: https://github.com/apache/flink/pull/20133#discussion_r913032001
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperator.java:
##########
@@ -51,9 +51,9 @@ public void handleOperatorEvent(OperatorEvent evt) {
}
@Override
- public void finish() throws Exception {
+ public void close() throws Exception {
sinkFunction.accumulateFinalResults();
- super.finish();
+ super.close();
}
Review Comment:
The change has been originally contributed by @AHeise. I haven't evaluated
this in depth, however the original commit message suggests:
> DataStream#executeAndCollect expects the CollectSinkOperator to register
the accumulator at the end of the application or fails with some exception.
However, a stop-with-savepoint without drain would not trigger
CollectSinkOperator#finish and thus skip the registration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
