gyfora commented on code in PR #293:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/293#discussion_r913425841
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -230,4 +230,10 @@ public class KubernetesOperatorConfigOptions {
.defaultValue(10)
.withDescription(
"Max attempts of automatic reconcile retries on
recoverable errors.");
+
+ public static final ConfigOption<Boolean>
OPERATOR_JOB_UPGRADE_LAST_STATE_FALLBACK_ENABLED =
+
ConfigOptions.key("kubernetes.operator.job.upgrade.last-state-fallback.enabled")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription("Enables last-state fallback for
savepoint upgrade mode.");
Review Comment:
We should add a bit more detail here, when/why this would happen
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java:
##########
@@ -281,6 +282,11 @@ public static boolean
isKubernetesHAActivated(Configuration configuration) {
.equalsIgnoreCase(KubernetesHaServicesFactory.class.getCanonicalName());
}
+ public static boolean isLastStateFallbackEnabled(Configuration
configuration) {
+ return configuration.getBoolean(
+
KubernetesOperatorConfigOptions.OPERATOR_JOB_UPGRADE_LAST_STATE_FALLBACK_ENABLED);
+ }
+
Review Comment:
Do we need a utility method for this? The config.get is pretty self
explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
