PatrickRen commented on code in PR #19473:
URL: https://github.com/apache/flink/pull/19473#discussion_r913448420
##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/PulsarSinkOptions.java:
##########
@@ -128,6 +127,16 @@ private PulsarSinkOptions() {
"The allowed transaction recommit times if we meet
some retryable exception."
+ " This is used in Pulsar Transaction.");
+ public static final ConfigOption<Integer>
PULSAR_MAX_PENDING_MESSAGES_ON_PARALLELISM =
+ ConfigOptions.key(SINK_CONFIG_PREFIX + "maxPendingMessages")
+ .intType()
+ .defaultValue(1000)
+ .withDescription(
+ Description.builder()
+ .text(
+ "The maximum number of pending
messages in on sink parallelism.")
Review Comment:
"in **one** sink parallelism" I guess?
##########
docs/layouts/shortcodes/generated/pulsar_sink_configuration.html:
##########
@@ -20,6 +20,12 @@
<td>Boolean</td>
<td>If you enable this option and use
PulsarSerializationSchema.pulsarSchema(), we would consume and deserialize the
message by using Pulsar's <code class="highlighter-rouge">Schema</code>.</td>
</tr>
+ <tr>
+ <td><h5>pulsar.sink.maxPendingMessages</h5></td>
+ <td style="word-wrap: break-word;">1000</td>
+ <td>Integer</td>
+ <td>The maximum number of pending messages in on sink
parallelism.</td>
Review Comment:
Here also "in **one** sink parallelism" I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
