[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464682#comment-15464682
]
ASF GitHub Bot commented on FLINK-4580:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2473
[FLINK-4580] [rpc] Verify that the rpc endpoint supports the rpc gateway at
connect time
When calling RpcService.connect it is checked that the rpc endpoint
supports the specified
rpc gateway. If not, then a RpcConnectionException is thrown. The
verification is implemented
as an additional message following after the Identify message. The reason
for this is that
the ActorSystem won't wait for the Identify message to time out after it
has determined that
the specified actor does not exist. For user-level messages this seems to
be not the case and,
thus, we would have to wait for the timeout.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink addGatewayEndpointCheck
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2473
----
commit 189fb14ddf30726f537f681e800c111ba9bc7c81
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2016-09-05T10:13:29Z
[FLINK-4580] [rpc] Verify that the rpc endpoint supports the rpc gateway at
connect time
When calling RpcService.connect it is checked that the rpc endpoint
supports the specified
rpc gateway. If not, then a RpcConnectionException is thrown. The
verification is implemented
as an additional message following after the Identify message. The reason
for this is that
the ActorSystem won't wait for the Identify message to time out after it
has determined that
the specified actor does not exist. For user-level messages this seems to
be not the case and,
thus, we would have to wait for the timeout.
----
> Check that the RpcEndpoint supports the specified RpcGateway
> ------------------------------------------------------------
>
> Key: FLINK-4580
> URL: https://issues.apache.org/jira/browse/FLINK-4580
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.2.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the
> {{RpcGateway}}. At the moment, it is not checked whether the {{RpcEndpoint}}
> actually supports the specified {{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding
> {{RpcEndpoint}} supports the specified {{RpcGateway}}. If not, then we can
> let the connect method fail fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
