akalash commented on code in PR #19864:
URL: https://github.com/apache/flink/pull/19864#discussion_r915654734
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java:
##########
@@ -493,6 +498,15 @@ private CompletableFuture<CompletedCheckpoint>
triggerSavepointInternal(
return resultFuture;
}
+ /**
+ * @param isPeriodic Flag indicating whether this triggered checkpoint is
periodic.
+ * @return a future to the completed checkpoint.
+ */
+ public CompletableFuture<CompletedCheckpoint>
triggerCheckpointFromCheckpointThread(
+ boolean isPeriodic) {
Review Comment:
The same point about tests. But perhaps, I can migrate these tests to
another method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
