lsyldliu commented on code in PR #20001:
URL: https://github.com/apache/flink/pull/20001#discussion_r916138087


##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/ExecutionContext.java:
##########
@@ -53,12 +54,14 @@ public class ExecutionContext {
     // Members that should be reused in the same session.
     private final Configuration flinkConfig;
     private final SessionState sessionState;
-    private final URLClassLoader classLoader;
+    private final MutableURLClassLoader classLoader;

Review Comment:
   Your start point is very good, but we can't remove it now. The related test 
in `set.q` which use hive dialect and udf will failed, because 
`HiveFunctionDefinitionFactory` load user defined function using thread context 
classloader. I have opened a seperated 
[issue](https://issues.apache.org/jira/browse/FLINK-28451)  to address it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to