LadyForest commented on code in PR #182:
URL: https://github.com/apache/flink-table-store/pull/182#discussion_r916513394
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/AppendOnlyWriter.java:
##########
@@ -92,22 +108,30 @@ public void write(RowData rowData) throws Exception {
@Override
public Increment prepareCommit() throws Exception {
- List<DataFileMeta> newFiles = new ArrayList<>();
+ submitCompaction();
Review Comment:
> Add new Files first, and then submitCompaction?
Could you explain more details about why the order matters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
