morhidi commented on PR #304: URL: https://github.com/apache/flink-kubernetes-operator/pull/304#issuecomment-1178737402
> The changes look good but I think we generally want to get rid of the word `dynamic` from the naming of methods, variables, example files. This is a config override logic and it's not more dynamic than anything else in this context. > > In Flink the `GlobalConfiguration.loadConfiguration(dynamicConfiguraition)` naming comes from the fact that those are configs provided at job submission time "dynamically" compared to the hardocded flink conf yaml. Thanks @gyfora got rid of it, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
