[ https://issues.apache.org/jira/browse/FLINK-23528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564216#comment-17564216 ]
Danny Cranmer commented on FLINK-23528: --------------------------------------- Hey [~arvid], we are finishing up this issue, but have a question around one of the changes you made in the original PR: - https://github.com/apache/flink/pull/17189/commits/3bae510b7af508ecf7c0569df34c307cacf08c8f This change looks a little out of place in this PR, do you remember why you made this change? > stop-with-savepoint can fail with FlinkKinesisConsumer > ------------------------------------------------------ > > Key: FLINK-23528 > URL: https://issues.apache.org/jira/browse/FLINK-23528 > Project: Flink > Issue Type: Bug > Components: Connectors / Kinesis > Affects Versions: 1.11.3, 1.13.1, 1.12.4, 1.14.3, 1.15.0 > Reporter: Piotr Nowojski > Assignee: Krzysztof Dziolak > Priority: Critical > Labels: pull-request-available, stale-assigned > Fix For: 1.15.2 > > > {{FlinkKinesisConsumer#cancel()}} (inside > {{KinesisDataFetcher#shutdownFetcher()}}) shouldn't be interrupting source > thread. Otherwise, as described in FLINK-23527, network stack can be left in > an invalid state and downstream tasks can encounter deserialisation errors. -- This message was sent by Atlassian Jira (v8.20.10#820010)