JingsongLi commented on code in PR #182:
URL: https://github.com/apache/flink-table-store/pull/182#discussion_r917496474
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/AppendOnlyWriter.java:
##########
@@ -93,21 +109,30 @@ public void write(RowData rowData) throws Exception {
@Override
public Increment prepareCommit() throws Exception {
List<DataFileMeta> newFiles = new ArrayList<>();
-
if (writer != null) {
writer.close();
newFiles.addAll(writer.result());
// Reopen the writer to accept further records.
- writer = createRollingRowWriter();
+ writer =
+ createRollingRowWriter(
+ schemaId,
+ fileFormat,
+ targetFileSize,
+ writeSchema,
+ pathFactory,
+ new LongCounter(getMaxSequenceNumber(newFiles) +
1));
Review Comment:
`new LongCounter(getMaxSequenceNumber(newFiles) + 1)`.
Introduce a class member counter?
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/AppendOnlyWriter.java:
##########
@@ -62,23 +73,28 @@ public AppendOnlyWriter(
FileFormat fileFormat,
long targetFileSize,
RowType writeSchema,
- long maxWroteSeqNumber,
+ LinkedList<DataFileMeta> toCompact,
Review Comment:
toCompact => restoreFiles?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
