simplejason commented on code in PR #20212:
URL: https://github.com/apache/flink/pull/20212#discussion_r917598411
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/backpressure/job-overview-drawer-backpressure.component.html:
##########
@@ -17,14 +17,17 @@
-->
<nz-table
- class="no-border small full-height"
- [nzSize]="'small'"
+ nzSize="small"
[nzLoading]="isLoading"
[nzData]="listOfSubTaskBackpressure"
- [nzScroll]="{ y: 'calc( 100vh - 72px )' }"
+ [nzScroll]="{ y: 'calc( 100% - 90px )' }"
[nzWidthConfig]="['33.33%', '33.33%', '33.33%']"
[nzFrontPagination]="false"
[nzShowPagination]="false"
+ [nzVirtualItemSize]="virtualItemSize"
+ [nzVirtualMinBufferPx]="300"
Review Comment:
nit: Do we need a variable `virtualItemSize` to set the height? If we don't
need to change it, it's better to set it with `[nzVirtualItemSize]="36"`.(Of
course it's okay for me to keep it as it is)
##########
flink-runtime-web/web-dashboard/src/app/pages/job-manager/log-list/job-manager-log-list.component.ts:
##########
@@ -40,20 +46,38 @@ export class JobManagerLogListComponent implements OnInit {
public listOfLog: JobManagerLogItem[] = [];
public isLoading = true;
+ public height = 650;
Review Comment:
Unused variable
##########
flink-runtime-web/web-dashboard/src/app/pages/task-manager/logs/task-manager-logs.component.ts:
##########
@@ -32,29 +35,30 @@ import { TaskManagerLocalService } from
'../task-manager-local.service';
changeDetection: ChangeDetectionStrategy.OnPush
})
export class TaskManagerLogsComponent implements OnInit, OnDestroy {
- public readonly editorOptions: EditorOptions = flinkEditorOptions;
-
+ public editorOptions: EditorOptions;
public logs = '';
public loading = true;
- public taskManagerDetail: TaskManagerDetail;
+ public taskManagerId: string;
+ public downloadUrl = '';
+ public downloadName = '';
private readonly destroy$ = new Subject<void>();
constructor(
private readonly taskManagerService: TaskManagerService,
- private readonly taskManagerLocalService: TaskManagerLocalService,
- private readonly cdr: ChangeDetectorRef
- ) {}
+ private readonly configService: ConfigService,
+ private activatedRoute: ActivatedRoute,
+ private readonly cdr: ChangeDetectorRef,
+ @Inject(TASK_MANAGER_MODULE_CONFIG) readonly moduleConfig: ModuleConfig
+ ) {
+ this.editorOptions = moduleConfig.editorOptions ||
TASK_MANAGER_MODULE_DEFAULT_CONFIG.editorOptions;
+ }
public ngOnInit() {
- this.taskManagerLocalService
- .taskManagerDetailChanges()
- .pipe(first(), takeUntil(this.destroy$))
- .subscribe(data => {
- this.taskManagerDetail = data;
- this.reload();
- this.cdr.markForCheck();
- });
+ this.taskManagerId =
this.activatedRoute.parent!.snapshot.params.taskManagerId;
+ this.downloadUrl =
`${this.configService.BASE_URL}taskmanagers/${this.taskManagerId}/log`;
Review Comment:
```diff
// slash added before `taskmanagers`
-${this.configService.BASE_URL}taskmanagers/${this.taskManagerId}/log
+${this.configService.BASE_URL}/taskmanagers/${this.taskManagerId}/log
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
