Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2451
@tillrohrmann , thanks for your review. I changed the pr based on your
advice, including ï¼
1. Modify UnmatchedLeaderSessionIDException to LeaderSessionIDException,
format code style and method comment, and add checkNotNull to constructor
2. Format code style and method comment of ResourceManager
3. Group the TaskExecutorGateway and the InstanceID into a
TaskExecutorRegistration
4. Modify testcases which are expected to throw exception at
ResourceManagerTest
Besides, I don't understand this comment of yours: "Should we fail or
decline the registration here? So either sending an exception or a
RegistrationResponse.Decline message.". Do you means you prefer to sending a
Decline message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
