SteNicholas opened a new pull request, #312:
URL: https://github.com/apache/flink-kubernetes-operator/pull/312
## What is the purpose of the change
Currently the JOSDK metrics forwarder logic doesn't implement the
`timeControllerExecution` function. We should implement it with the following
logic.
1. Measure execution time for successful failed executions
2. Based on the name of the ControllerExectution (reconcile/cleanup) and
controller name, track the following histogram metrics metrics
`JOSDK.{ControllerExecution.controllerName}.{ControllerExecution.name}.{ControllerExecution.successTypeName}/failed`
## Brief change log
- Introduces the `Histogram` metric in the `timeControllerExecution` with
the metric name format
`JOSDK.{ControllerExecution.controllerName}.{ControllerExecution.name}.{ControllerExecution.successTypeName}/failed`.
## Verifying this change
- *`OperatorJosdkMetricsTest` adds the `testTimeControllerExecution` to
verify whether the `Histogram` metric is correct.*
- The `Histogram` metric in the `timeControllerExecution` is as follows:
```
-- Histograms
-----------------------------------------------------------------
flink-kubernetes-operator-7679966cd6-d4p2g.k8soperator.default.flink-kubernetes-operator.system.JOSDK.flinkdeploymentcontroller.reconcile.resource.Nanos:
count=6, min=6517100, max=1198002100, mean=3.375813833333334E8,
stddev=4.5900281423332655E8, p50=1.997605E8, p75=6.04624825E8, p95=1.1980021E9,
p98=1.1980021E9, p99=1.1980021E9, p999=1.1980021E9
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
(yes / **no**)
- Core observer or reconciler logic that is regularly executed: (yes /
**no**)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
