bgeng777 commented on code in PR #316:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/316#discussion_r919604652
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/service/FlinkServiceTest.java:
##########
@@ -293,7 +293,7 @@ public void testClusterInfoRestCompatibility() throws
JsonProcessingException {
String flink14Response =
"{\"refresh-interval\":3000,\"timezone-name\":\"Coordinated
Universal
Time\",\"timezone-offset\":0,\"flink-version\":\"1.14.4\",\"flink-revision\":\"895c609
@
2022-02-25T11:57:14+01:00\",\"features\":{\"web-submit\":false,\"web-cancel\":false}}";
String flink15Response =
- "{\"refresh-interval\":3000,\"timezone-name\":\"Coordinated
Universal
Time\",\"timezone-offset\":0,\"flink-version\":\"1.15.0\",\"flink-revision\":\"3a4c113
@
2022-04-20T19:50:32+02:00\",\"features\":{\"web-submit\":false,\"web-cancel\":false}}";
+ "{\"refresh-interval\":3000,\"timezone-name\":\"Coordinated
Universal
Time\",\"timezone-offset\":0,\"flink-version\":\"1.15.1\",\"flink-revision\":\"3a4c113
@
2022-04-20T19:50:32+02:00\",\"features\":{\"web-submit\":false,\"web-cancel\":false}}";
Review Comment:
Maybe the fink-revision number/date should be changed 1.15.1's as well. The
revision number should be
[f494be6](https://github.com/apache/flink/commit/f494be6956e850d4d1c9fd50b79e5a8dd5b53e47).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
