gaoyunhaii commented on code in PR #19983: URL: https://github.com/apache/flink/pull/19983#discussion_r921759245
########## flink-streaming-java/src/main/java/org/apache/flink/streaming/util/retryable/AsyncRetryStrategies.java: ########## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.util.retryable; + +import org.apache.flink.streaming.api.functions.async.AsyncRetryPredicate; +import org.apache.flink.streaming.api.functions.async.AsyncRetryStrategy; +import org.apache.flink.util.Preconditions; + +import javax.annotation.Nonnull; + +import java.util.Collection; +import java.util.Optional; +import java.util.function.Predicate; + +/** Utility class to create concrete {@link AsyncRetryStrategy}. */ +public class AsyncRetryStrategies { + public static final NoRetryStrategy NO_RETRY_STRATEGY = new NoRetryStrategy(); + + /** NoRetryStrategy. */ + public static class NoRetryStrategy implements AsyncRetryStrategy { Review Comment: nit: could be private ########## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperator.java: ########## @@ -154,6 +193,20 @@ public void setup( default: throw new IllegalStateException("Unknown async mode: " + outputMode + '.'); } + if (asyncRetryStrategy.getRetryPredicate().resultPredicate().isPresent()) { + this.retryResultPredicate = + asyncRetryStrategy + .getRetryPredicate() + .resultPredicate() + .orElse(ignore -> false); + } + if (asyncRetryStrategy.getRetryPredicate().exceptionPredicate().isPresent()) { Review Comment: The `if` here is wrong. The `orElse` gives the default predict if user not set that, but with the `if`, in this case the predict will remain `null`. This also could be wrapped by if (retryEnabled) {... } -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
