[ 
https://issues.apache.org/jira/browse/FLINK-28583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567857#comment-17567857
 ] 

jackylau commented on FLINK-28583:
----------------------------------

hi [~chesnay] , what do you think ?

> make flink dist log4j dependency simple and clear
> -------------------------------------------------
>
>                 Key: FLINK-28583
>                 URL: https://issues.apache.org/jira/browse/FLINK-28583
>             Project: Flink
>          Issue Type: Improvement
>          Components: Deployment / Scripts
>    Affects Versions: 1.16.0
>            Reporter: jackylau
>            Priority: Major
>             Fix For: 1.16.0
>
>
> flink don't shade the log4j and want to put it flink/lib using shade 
> exclusion like thisĀ 
> {code:java}
> <excludes>
>    <!-- log4j 2 is bundled separately from the flink-dist jar -->
>    <exclude>org.apache.logging.log4j:*</exclude> {code}
> and add this to put them to flink/lib
> {code:java}
> <includes>
>    <include>org.apache.logging.log4j:log4j-api</include>
>    <include>org.apache.logging.log4j:log4j-core</include>
>    <include>org.apache.logging.log4j:log4j-slf4j-impl</include>
>    <include>org.apache.logging.log4j:log4j-1.2-api</include>
> </includes> {code}
> i suggest to make the log4j to provided.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to