xintongsong commented on code in PR #20236:
URL: https://github.com/apache/flink/pull/20236#discussion_r924301011
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##########
@@ -111,7 +112,7 @@
public class RestClient implements AutoCloseableAsync {
private static final Logger LOG =
LoggerFactory.getLogger(RestClient.class);
- private static final ObjectMapper objectMapper =
RestMapperUtils.getStrictObjectMapper();
Review Comment:
Changes to the visibility and `final` keyword in this file do not make sense
to me.
Is the `RestClient` common or specific to the runtime?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerSpecification.java:
##########
@@ -48,6 +49,6 @@ public interface RestHandlerSpecification {
* @return Collection of supported API versions
*/
default Collection<RestAPIVersion> getSupportedAPIVersions() {
- return Collections.singleton(RestAPIVersion.V1);
+ return Collections.singleton(RuntimeRestAPIVersion.V1);
Review Comment:
Is this a common interface or specific to runtime?
- If common, it should not return a `RuntimeRestAPIVersion`
- If specific to runtime, the return type should be updated, as well as the
name of the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
