wanglijie95 commented on code in PR #20218:
URL: https://github.com/apache/flink/pull/20218#discussion_r925391760
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceAllocationStrategy.java:
##########
@@ -37,10 +38,32 @@ public interface ResourceAllocationStrategy {
* @param missingResources resource requirements that are not yet
fulfilled, indexed by jobId
* @param taskManagerResourceInfoProvider provide the registered/pending
resources of the
* current cluster
+ * @param blockedTaskManagerChecker blocked task manager checker
* @return a {@link ResourceAllocationResult} based on the current status,
which contains
* whether the requirements can be fulfilled and the actions to take
*/
ResourceAllocationResult tryFulfillRequirements(
Map<JobID, Collection<ResourceRequirement>> missingResources,
- TaskManagerResourceInfoProvider taskManagerResourceInfoProvider);
+ TaskManagerResourceInfoProvider taskManagerResourceInfoProvider,
+ BlockedTaskManagerChecker blockedTaskManagerChecker);
+
+ /**
+ * Try to make an allocation decision to fulfill the resource
requirements. The strategy
+ * generates a series of actions to take, based on the current status.
+ *
+ * <p>Notice: For performance considerations, modifications might be
performed directly on the
+ * input arguments. If the arguments are reused elsewhere, please make a
deep copy in advance.
+ *
+ * @param missingResources resource requirements that are not yet
fulfilled, indexed by jobId
+ * @param taskManagerResourceInfoProvider provide the registered/pending
resources of the
+ * current cluster
+ * @return a {@link ResourceAllocationResult} based on the current status,
which contains
+ * whether the requirements can be fulfilled and the actions to take
+ */
+ default ResourceAllocationResult tryFulfillRequirements(
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
