qingwei91 commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r925920284
########## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownVisitor.java: ########## @@ -53,7 +52,6 @@ * Visitor to walk a Expression AST. Produces a String that can be used to pushdown the filter, * return Optional.empty() if we cannot pushdown the filter. */ -@Public Review Comment: Hi @JingGe , I believe it has to be PublicEvolving because this class is returned by a public method in JdbcDialect, which is a PublicEvolving class. I will sort out the commit, sorry for the confusion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
