reswqa commented on code in PR #20293:
URL: https://github.com/apache/flink/pull/20293#discussion_r926896614
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataSpiller.java:
##########
@@ -41,7 +43,15 @@ public class HsMemoryDataSpiller implements AutoCloseable {
/** One thread to perform spill operation. */
private final ExecutorService ioExecutor =
Executors.newSingleThreadScheduledExecutor(
- new ThreadFactoryBuilder().setNameFormat("hybrid spiller
thread").build());
+ new ThreadFactoryBuilder()
+ .setNameFormat("hybrid spiller thread")
+ // It is more appropriate to use task fail over
than exit JVM here,
+ // but the task thread will bring some extra
overhead to check the
+ // exception information set by other thread. As
the spiller thread will
+ // not encounter exceptions in most cases, we
temporarily choose the
+ // form of fatal error to deal except thrown by
spiller thread.
+
.setUncaughtExceptionHandler(FatalExitExceptionHandler.INSTANCE)
+ .build());
Review Comment:
ok, changes about spiller are separate to a single hot-fix commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
