lsyldliu commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r927222651
########## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser.ddl; + +import org.apache.flink.sql.parser.ExtendedSqlNode; +import org.apache.flink.sql.parser.ddl.constraint.SqlTableConstraint; +import org.apache.flink.sql.parser.error.SqlValidateException; + +import org.apache.calcite.sql.SqlCreate; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlOperator; +import org.apache.calcite.sql.SqlSpecialOperator; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.util.ImmutableNullableList; + +import javax.annotation.Nonnull; + +import java.util.List; +import java.util.stream.Collectors; + +/** CREATE TABLE AS SELECT DDL sql call. */ +public class SqlCreateTableAs extends SqlCreate implements ExtendedSqlNode { + + public static final SqlSpecialOperator OPERATOR = + new SqlSpecialOperator("CREATE TABLE AS SELECT", SqlKind.OTHER_DDL); + + private final SqlCreateTable sqlCreateTable; + private final SqlNode asQuery; + + public SqlCreateTableAs(SqlCreateTable sqlCreateTable, SqlNode asQuery) { + super( + OPERATOR, + sqlCreateTable.getParserPosition(), + sqlCreateTable.getReplace(), + sqlCreateTable.isIfNotExists()); + this.sqlCreateTable = sqlCreateTable; + this.asQuery = asQuery; + } + + @Override + public @Nonnull SqlOperator getOperator() { + return OPERATOR; + } + + @Override + public @Nonnull List<SqlNode> getOperandList() { Review Comment: The following code is enough: `ImmutableNullableList.of(createTable, asQuery);` ########## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser.ddl; + +import org.apache.flink.sql.parser.ExtendedSqlNode; +import org.apache.flink.sql.parser.ddl.constraint.SqlTableConstraint; +import org.apache.flink.sql.parser.error.SqlValidateException; + +import org.apache.calcite.sql.SqlCreate; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlOperator; +import org.apache.calcite.sql.SqlSpecialOperator; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.util.ImmutableNullableList; + +import javax.annotation.Nonnull; + +import java.util.List; +import java.util.stream.Collectors; + +/** CREATE TABLE AS SELECT DDL sql call. */ Review Comment: add more annotation ########## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser.ddl; + +import org.apache.flink.sql.parser.ExtendedSqlNode; +import org.apache.flink.sql.parser.ddl.constraint.SqlTableConstraint; +import org.apache.flink.sql.parser.error.SqlValidateException; + +import org.apache.calcite.sql.SqlCreate; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlOperator; +import org.apache.calcite.sql.SqlSpecialOperator; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.util.ImmutableNullableList; + +import javax.annotation.Nonnull; + +import java.util.List; +import java.util.stream.Collectors; + +/** CREATE TABLE AS SELECT DDL sql call. */ +public class SqlCreateTableAs extends SqlCreate implements ExtendedSqlNode { + + public static final SqlSpecialOperator OPERATOR = + new SqlSpecialOperator("CREATE TABLE AS SELECT", SqlKind.OTHER_DDL); + + private final SqlCreateTable sqlCreateTable; + private final SqlNode asQuery; + + public SqlCreateTableAs(SqlCreateTable sqlCreateTable, SqlNode asQuery) { + super( + OPERATOR, + sqlCreateTable.getParserPosition(), + sqlCreateTable.getReplace(), + sqlCreateTable.isIfNotExists()); + this.sqlCreateTable = sqlCreateTable; Review Comment: I think maybe we can try to refactor this, it seems to introduce `SqlCreateTableLike` and `SqlCreateTableAs ` as subclass more clear, but maybe it is a huge work. ########## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser.ddl; + +import org.apache.flink.sql.parser.ExtendedSqlNode; +import org.apache.flink.sql.parser.ddl.constraint.SqlTableConstraint; +import org.apache.flink.sql.parser.error.SqlValidateException; + +import org.apache.calcite.sql.SqlCreate; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlOperator; +import org.apache.calcite.sql.SqlSpecialOperator; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.util.ImmutableNullableList; + +import javax.annotation.Nonnull; + +import java.util.List; +import java.util.stream.Collectors; + +/** CREATE TABLE AS SELECT DDL sql call. */ Review Comment: ```suggestion /** * SqlNode to describe the CREATE TABLE AS syntax. The CTAS syntax is different from CREATE TABLE * syntax, which also create the pipeline to sync the data from the source to the derived table. * * <p>Example: A DDL like the one below for creating a `derived_table` * * <pre>{@code * CREATE TABLE base_table ( * id BIGINT, * name STRING, * tstmp TIMESTAMP, * PRIMARY KEY(id) * ) WITH ( * ‘connector’ = ‘kafka’, * ‘connector.starting-offset’: ‘12345’, * ‘format’ = ‘json’ * ) * * CREATE TABLE derived_table * WITH ( * 'connector' = 'jdbc', * 'url' = 'http://localhost:10000', * 'table-name' = 'syncedTable' * ) * AS SELECT * FROM base_table_1; * }</pre> */``` ########## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser.ddl; + +import org.apache.flink.sql.parser.ExtendedSqlNode; +import org.apache.flink.sql.parser.ddl.constraint.SqlTableConstraint; +import org.apache.flink.sql.parser.error.SqlValidateException; + +import org.apache.calcite.sql.SqlCreate; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlOperator; +import org.apache.calcite.sql.SqlSpecialOperator; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.util.ImmutableNullableList; + +import javax.annotation.Nonnull; + +import java.util.List; +import java.util.stream.Collectors; + +/** CREATE TABLE AS SELECT DDL sql call. */ +public class SqlCreateTableAs extends SqlCreate implements ExtendedSqlNode { + + public static final SqlSpecialOperator OPERATOR = + new SqlSpecialOperator("CREATE TABLE AS SELECT", SqlKind.OTHER_DDL); + + private final SqlCreateTable sqlCreateTable; + private final SqlNode asQuery; + + public SqlCreateTableAs(SqlCreateTable sqlCreateTable, SqlNode asQuery) { + super( + OPERATOR, + sqlCreateTable.getParserPosition(), + sqlCreateTable.getReplace(), + sqlCreateTable.isIfNotExists()); + this.sqlCreateTable = sqlCreateTable; + this.asQuery = asQuery; + } + + @Override + public @Nonnull SqlOperator getOperator() { + return OPERATOR; + } + + @Override + public @Nonnull List<SqlNode> getOperandList() { + SqlNode[] sqlNodes = new SqlNode[sqlCreateTable.getOperandList().size() + 1]; + List<SqlNode> operandList = sqlCreateTable.getOperandList(); + for (int i = 0; i < operandList.size(); i++) { + sqlNodes[i] = operandList.get(i); + } + sqlNodes[sqlNodes.length - 1] = asQuery; + return ImmutableNullableList.copyOf(sqlNodes); + } + + @Override + public void validate() throws SqlValidateException { + sqlCreateTable.validate(); + if (sqlCreateTable.isTemporary()) { + throw new SqlValidateException( + getParserPosition(), + "CREATE TABLE AS SELECT syntax does not yet support creating temporary table."); Review Comment: support to create or support creating? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
