zhuzhurk commented on code in PR #20341:
URL: https://github.com/apache/flink/pull/20341#discussion_r927412543
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/BlocklistDeclarativeSlotPool.java:
##########
@@ -90,11 +90,29 @@ public Collection<SlotOffer> registerSlots(
if (!isBlockedTaskManager(taskManagerLocation.getResourceID())) {
return super.registerSlots(slots, taskManagerLocation,
taskManagerGateway, currentTime);
} else {
- LOG.debug("Reject slots {} from a blocked TaskManager {}.", slots,
taskManagerLocation);
- return Collections.emptySet();
+ LOG.debug(
Review Comment:
Maybe move the log to `internalOfferSlotsFromBlockedTaskManager` and also
log about the accepted/reject slots?
e.g. Received 3 slots from a blocked TaskManager XXX, 1 was accepted before:
[A], 2 was rejected: [B,C].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
