dannycranmer commented on code in PR #20133:
URL: https://github.com/apache/flink/pull/20133#discussion_r927497905
##########
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java:
##########
@@ -852,6 +852,15 @@ protected void deregisterStreamConsumer() {
StreamConsumerRegistrarUtil.deregisterStreamConsumers(configProps,
streams);
}
+ /**
+ * Gracefully stops shardConsumersExecutor without interrupting running
threads. Allows test to
+ * override this to simulate exception for shutdown logic.
+ */
+ @VisibleForTesting
Review Comment:
You have marked this as `@VisibleForTesting`, but it is not called from any
tests, can you make it private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
