luoyuxia commented on PR #20211: URL: https://github.com/apache/flink/pull/20211#issuecomment-1192402658
> I think the existing tests are not enough. Actually, this pull request is to fix a bug that the HiveFunctionFactory uses the wrong classloader. A bug means there will be exceptions under some scenarios. Could you add tests to reproduce that? I remove the method `wrapClassLoader` in [...-client/src/main/java/org/apache/flink/table/client/gateway/context/ExecutionContext.java](https://github.com/apache/flink/pull/20211/files#diff-e4eedd6614c74331053ac2ecbda71529fe00990ab3b20f3a381eff5366282f1a), and the usage of this method, so that the exception can be reproduced in test `CliClientITCase.testSqlStatements` as the the jira [FLINK-28451](https://issues.apache.org/jira/browse/FLINK-28451) descrips if without this fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
