gaborgsomogyi commented on code in PR #20206: URL: https://github.com/apache/flink/pull/20206#discussion_r928147951
########## flink-runtime/src/main/java/org/apache/flink/runtime/security/token/HBaseDelegationTokenProvider.java: ########## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.security.token; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.util.HadoopUtils; +import org.apache.flink.util.Preconditions; + +import org.apache.hadoop.security.Credentials; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.security.token.Token; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Closeable; +import java.io.IOException; +import java.lang.reflect.InvocationTargetException; +import java.util.Objects; +import java.util.Optional; + +/** Delegation token provider implementation for HBase. */ +public class HBaseDelegationTokenProvider implements DelegationTokenProvider { + + private static final Logger LOG = LoggerFactory.getLogger(HBaseDelegationTokenProvider.class); + + org.apache.hadoop.conf.Configuration hbaseConf; + + @Override + public String serviceName() { + return "hbase"; + } + + @Override + public void init(Configuration configuration) throws Exception { + hbaseConf = getHBaseConfiguration(configuration); + } + + private org.apache.hadoop.conf.Configuration getHBaseConfiguration(Configuration conf) { + org.apache.hadoop.conf.Configuration hbaseConf = null; + try { + org.apache.hadoop.conf.Configuration hadoopConf = + HadoopUtils.getHadoopConfiguration(conf); + // ---- + // Intended call: HBaseConfiguration.create(conf); + hbaseConf = + (org.apache.hadoop.conf.Configuration) + Class.forName("org.apache.hadoop.hbase.HBaseConfiguration") + .getMethod("create", org.apache.hadoop.conf.Configuration.class) + .invoke(null, hadoopConf); + // ---- + + } catch (InvocationTargetException + | NoSuchMethodException + | IllegalAccessException + | ClassNotFoundException e) { + LOG.info( + "HBase is not available (not packaged with this application): {} : \"{}\".", + e.getClass().getSimpleName(), + e.getMessage()); + } + return hbaseConf; + } + + @Override + public boolean delegationTokensRequired() throws Exception { + try { + if (!HadoopUtils.isKerberosSecurityEnabled(UserGroupInformation.getCurrentUser())) { + return false; + } + } catch (IOException e) { + LOG.debug("Hadoop Kerberos is not enabled."); + return false; + } + return Objects.nonNull(hbaseConf) + && hbaseConf.get("hbase.security.authentication").equals("kerberos"); + } + + @Override + public Optional<Long> obtainDelegationTokens(Credentials credentials) throws Exception { + Token<?> token; + try { + Preconditions.checkNotNull(hbaseConf); + try { + LOG.info("Obtaining Kerberos security token for HBase"); + // ---- + // Intended call: Token<AuthenticationTokenIdentifier> token = + // TokenUtil.obtainToken(conf); + token = + (Token<?>) + Class.forName("org.apache.hadoop.hbase.security.token.TokenUtil") + .getMethod( + "obtainToken", + org.apache.hadoop.conf.Configuration.class) + .invoke(null, hbaseConf); + } catch (NoSuchMethodException e) { + // for HBase 2 + + // ---- + // Intended call: ConnectionFactory connectionFactory = + // ConnectionFactory.createConnection(conf); + Closeable connectionFactory = + (Closeable) + Class.forName("org.apache.hadoop.hbase.client.ConnectionFactory") + .getMethod( + "createConnection", + org.apache.hadoop.conf.Configuration.class) + .invoke(null, hbaseConf); + // ---- + Class<?> connectionClass = + Class.forName("org.apache.hadoop.hbase.client.Connection"); + // ---- + // Intended call: Token<AuthenticationTokenIdentifier> token = + // TokenUtil.obtainToken(connectionFactory); + token = + (Token<?>) + Class.forName("org.apache.hadoop.hbase.security.token.TokenUtil") + .getMethod("obtainToken", connectionClass) + .invoke(null, connectionFactory); + if (null != connectionFactory) { + connectionFactory.close(); + } + } + if (token == null) { + LOG.error("No Kerberos security token for HBase available"); + } else { + credentials.addToken(token.getService(), token); + LOG.info("Added HBase Kerberos security token to credentials."); + } + } catch (ClassNotFoundException + | NoSuchMethodException + | IllegalAccessException + | InvocationTargetException + | IOException e) { + LOG.info( + "HBase is not available (failed to obtain delegation tokens): {} : \"{}\".", + e.getClass().getSimpleName(), + e.getMessage()); + } + + // HBase does not support to renew the delegation token currently + // https://cwiki.apache.org/confluence/display/HADOOP2/Hbase+HBaseTokenAuthentication + return Optional.empty(); Review Comment: In the meantime I was thinking. It's clear that it's not possible to renew the token which is fine. On the other hand if we give back `Optional.empty()` here then Flink will never ever re-obtain HBase token when it's the only active token provider. I think it would be good to give back expire date field if it's filled since we're re-obtaining the token and not renewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
