wanglijie95 commented on code in PR #20349:
URL: https://github.com/apache/flink/pull/20349#discussion_r928558858
##########
flink-runtime/src/main/java/org/apache/flink/runtime/blocklist/DefaultBlocklistHandler.java:
##########
@@ -111,26 +111,27 @@ private void assertRunningInMainThread() {
public void addNewBlockedNodes(Collection<BlockedNode> newNodes) {
assertRunningInMainThread();
- Collection<BlockedNode> newlyAddedOrMerged =
blocklistTracker.addNewBlockedNodes(newNodes);
- if (!newlyAddedOrMerged.isEmpty()) {
+ BlockedNodeAdditionResult result =
blocklistTracker.addNewBlockedNodes(newNodes);
+ Collection<BlockedNode> newlyAddedNodes = result.getNewlyAddedNodes();
+ if (!newlyAddedNodes.isEmpty()) {
if (log.isDebugEnabled()) {
log.debug(
- "Newly added/merged {} blocked nodes, details: {}."
+ "Newly added {} blocked nodes, details: {}."
+ " Total {} blocked nodes currently, details:
{}.",
- newlyAddedOrMerged.size(),
- newlyAddedOrMerged,
+ newlyAddedNodes.size(),
+ newlyAddedNodes,
blocklistTracker.getAllBlockedNodes().size(),
blocklistTracker.getAllBlockedNodes());
} else {
log.info(
- "Newly added/merged {} blocked nodes. Total {} blocked
nodes currently.",
- newlyAddedOrMerged.size(),
+ "Newly added {} blocked nodes. Total {} blocked nodes
currently.",
+ newlyAddedNodes.size(),
blocklistTracker.getAllBlockedNodes().size());
}
- blocklistListeners.forEach(
- listener ->
listener.notifyNewBlockedNodes(newlyAddedOrMerged));
- blocklistContext.blockResources(newlyAddedOrMerged);
+ Collection<BlockedNode> allNodes = result.getAllNodes();
Review Comment:
Good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
