wuchong commented on code in PR #20247:
URL: https://github.com/apache/flink/pull/20247#discussion_r928660329
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java:
##########
@@ -81,6 +90,15 @@ public interface TableEnvironmentInternal extends
TableEnvironment {
* @param operation The operation to be executed.
* @return the content of the execution result.
*/
+ TableResultInternal executeOperation(Operation operation);
Review Comment:
This sounds we can encapsulate the logic in the internal implementation
instead of exposing them on the interface. From the perspective of users, they
shouldn't care about the difference between `executeInternal()` and
`executeOperation()`. It's very easy to call the wrong method for the users who
use the `TableEnvironmentInternl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
