JingsongLi commented on code in PR #236:
URL: https://github.com/apache/flink-table-store/pull/236#discussion_r929470611
##########
flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkCatalog.java:
##########
@@ -284,14 +284,19 @@ private UpdateSchema toUpdateSchema(
}));
Map<String, String> normalizedProperties = new HashMap<>(properties);
normalizedProperties.remove(PRIMARY_KEY_IDENTIFIER);
+ String pkAsString = properties.get(PRIMARY_KEY_IDENTIFIER);
+ List<String> primaryKeys =
Review Comment:
We can add this check in `UpdateSchema`.
- Primary / partition keys should in fields.
- Pk not null. (Or convert pk fields to not null)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
