fredia commented on code in PR #20152:
URL: https://github.com/apache/flink/pull/20152#discussion_r930579497
##########
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java:
##########
@@ -87,9 +87,14 @@ protected <K> CheckpointableKeyedStateBackend<K> restore(
String subtaskName = env.getTaskInfo().getTaskNameWithSubtasks();
ExecutionConfig executionConfig = env.getExecutionConfig();
+ env.getAsyncOperationsThreadPool();
+
ChangelogStateFactory changelogStateFactory = new
ChangelogStateFactory();
CheckpointableKeyedStateBackend<K> keyedStateBackend =
ChangelogBackendRestoreOperation.restore(
+ env.getJobID(),
+ env.getAsyncOperationsThreadPool(),
+ env.getTaskManagerInfo().getConfiguration(),
Review Comment:
> Do you mean changing StateChangelogStorageFactory interface and passing
ExecutionConfig to createStorageView instead of Configuration?
I tend to put `PERIODIC_MATERIALIZATION_INTERVAL` directly as a parameter
instead of `xxConfiguration`.
> it should be env.getJobConfiguration()ideally merged
withenv.getTaskManagerInfo().getConfiguration()`, right?
I'm not sure. Currently, most configuration is in
`env.getTaskManagerInfo().getConfiguration()` or `env.getTaskConfiguration()`,
which is better to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
