reswqa commented on code in PR #20371:
URL: https://github.com/apache/flink/pull/20371#discussion_r931129805
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataSpiller.java:
##########
@@ -145,8 +149,22 @@ private void setBufferWithHeader(Buffer buffer,
ByteBuffer[] bufferWithHeaders,
bufferWithHeaders[index + 1] = buffer.getNioBufferReadable();
}
- @Override
- public void close() throws Exception {
+ private FileChannel openFileChannel(Path path) throws IOException {
+ return FileChannel.open(path, StandardOpenOption.CREATE_NEW,
StandardOpenOption.WRITE);
+ }
+
+ public void close() {
ioExecutor.shutdown();
}
+
+ public void release() {
Review Comment:
Good suggestion, added it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
