wsry commented on code in PR #20351:
URL: https://github.com/apache/flink/pull/20351#discussion_r931817483
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java:
##########
@@ -676,11 +682,15 @@ private List<StreamEdge> createChain(
config.setChainIndex(chainIndex);
config.setOperatorName(streamGraph.getStreamNode(currentNodeId).getOperatorName());
+ LinkedHashSet<NonChainedOutput> transitiveOutputs = new
LinkedHashSet<>();
for (StreamEdge edge : transitiveOutEdges) {
- connect(startNodeId, edge);
+ NonChainedOutput output =
+
opIntermediateOutputs.get(edge.getSourceId()).get(edge);
+ transitiveOutputs.add(output);
+ connect(startNodeId, edge, output);
}
- config.setOutEdgesInOrder(transitiveOutEdges);
+ config.setStreamOutputsInOrder(new
ArrayList<>(transitiveOutputs));
Review Comment:
The outputs are already de-duplicated. Because ```transitiveOutputs``` is a
set and different edges share the same output use the same
```NonChainedOutput``` object. To make is more clear. I will add ```equal```
and ```hashCode``` to the ```NonChainedOutput``` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
