tisonkun commented on code in PR #19972:
URL: https://github.com/apache/flink/pull/19972#discussion_r932957550
##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/stop/LatestMessageStopCursor.java:
##########
@@ -18,36 +18,29 @@
package org.apache.flink.connector.pulsar.source.enumerator.cursor.stop;
-import org.apache.flink.connector.pulsar.source.enumerator.cursor.StopCursor;
import
org.apache.flink.connector.pulsar.source.enumerator.topic.TopicPartition;
import org.apache.pulsar.client.admin.PulsarAdmin;
-import org.apache.pulsar.client.api.Message;
-import org.apache.pulsar.client.api.MessageId;
import static
org.apache.flink.connector.pulsar.common.utils.PulsarExceptionUtils.sneakyAdmin;
/**
* A stop cursor that initialize the position to the latest message id. The
offsets initialization
* are taken care of by the {@code PulsarPartitionSplitReaderBase} instead of
by the {@code
- * PulsarSourceEnumerator}.
+ * PulsarSourceEnumerator}. We would include the latest message available in
Pulsar by default.
*/
-public class LatestMessageStopCursor implements StopCursor {
+public class LatestMessageStopCursor extends MessageIdStopCursor {
Review Comment:
I'd prefer to `implements StopCursor` and keep `MessageIdStopCursor` holds a
final `messageId`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
