JingsongLi commented on code in PR #255:
URL: https://github.com/apache/flink-table-store/pull/255#discussion_r933011387
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSourceReader.java:
##########
@@ -35,9 +35,10 @@
FileStoreSourceSplit,
FileStoreSourceSplitState> {
- public FileStoreSourceReader(SourceReaderContext readerContext, TableRead
tableRead) {
+ public FileStoreSourceReader(
+ SourceReaderContext readerContext, TableRead tableRead, Long
limit) {
Review Comment:
`@Nullable`
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSourceSplitReader.java:
##########
@@ -52,11 +54,12 @@
private long currentNumRead;
private RecordReader.RecordIterator<RowData> currentFirstBatch;
- public FileStoreSourceSplitReader(TableRead tableRead) {
+ public FileStoreSourceSplitReader(TableRead tableRead, Long limit) {
Review Comment:
`@Nullable`
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSourceSplitReader.java:
##########
@@ -52,11 +54,12 @@
private long currentNumRead;
private RecordReader.RecordIterator<RowData> currentFirstBatch;
- public FileStoreSourceSplitReader(TableRead tableRead) {
+ public FileStoreSourceSplitReader(TableRead tableRead, Long limit) {
this.tableRead = tableRead;
+ this.limit = limit;
this.splits = new LinkedList<>();
this.pool = new Pool<>(1);
- this.pool.add(new FileStoreRecordIterator());
+ this.pool.add(new FileStoreRecordIterator(limit));
Review Comment:
`FileStoreRecordIterator` is an inner class, it can just read `limit` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
